git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re: [PATCH 2/2] remote-curl.c: handle v1 when check_smart_http

From
Jeff King <peff@peff.net>
Date
Mar 29, 2021, 10:40 UTC
Message-ID
<YGGukSxGVnTeXae0@coredump.intra.peff.net>
In-Reply-To
<68765f14907111eb8e180024e87935e7@oschina.cn>
On Mon, Mar 29, 2021 at 05:30:29PM +0800, lilinchao@oschina.cn wrote:
Show 9 quoted lines
> >Anyway, that's all just an interesting side note. The client is happy
> >with either form (though it might be nice if we had tests for the "#
> >service" form; I suspect our tests don't cover that because they are all
> >using http-backend).
> >
> >Getting back to the patch at hand, if there is a server saying "version
> >1" without a "service" line, then I think that is a bug in that server.
> > 
> If the problem is on the server side, then, is this patch worth continuing?

IMHO, no. I think the response from gitee.com is violating the protocol spec. It would be nice to fix, but in practice it isn't all that important because somebody would have to manually set protocol.version=1 to see the problem.

-Peff
Previous: lilinchao@oschina.cn
Message 8 of 8 in “remote-curl.c: handle v1 when check_smart_http”
  1. 2/2 remote-curl.c: handle v1 when check_smart_httplilinchao@oschina.cn, Mar 24, 2021
  2. Junio C HamanoMar 24, 2021
  3. Junio C HamanoMar 24, 2021
  4. Jeff KingMar 26, 2021
  5. Jeff KingMar 26, 2021
  6. lilinchao@oschina.cnMar 25, 2021
  7. lilinchao@oschina.cnMar 29, 2021
  8. Jeff KingMar 29, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.