Re: [PATCH] fetch: show progress for packfile uri downloads

From: Jeff King <peff@peff.net>
Date: Mar 17, 2021, 19:21 UTC
Message-ID: <YFJWz5yIGng+a16k@coredump.intra.peff.net>
In-Reply-To: <pull.907.git.1616007794513.gitgitgadget@gmail.com>

On Wed, Mar 17, 2021 at 07:03:13PM +0000, Albert Cui via GitGitGadget wrote:

Show 7 quoted lines

> From: Albert Cui <albertqcui@gmail.com>
> 
> Git appears to hang when downloading packfiles as this part of the
> fetch is silent, causing user confusion. This change implements
> progress for the number of packfiles downloaded; a progress display
> for bytes would involve deeper changes at the http-fetch layer
> instead of fetch-pack, the caller.

I think this is an improvement, but I agree that a real byte display would be much better. I actually worked on this a long time ago for a very similar feature that we never quite pushed over the finish line. See patches 11 and 12 here:

  https://lore.kernel.org/git/20111110074330.GA27925@sigill.intra.peff.net/

(it might need some of the earlier refactoring, too, I'm not sure; and quite likely will need forward-porting as it has been 10 years).

-Peff