Re: [PATCH] format-patch: give an overview of what a "patch" message is

From: Jeff King <peff@peff.net>
Date: Mar 26, 2021, 08:45 UTC
Message-ID: <YF2fIhVUwBim47Wq@coredump.intra.peff.net>
In-Reply-To: <7c0aabe0-9240-950e-912f-0a195db7a144@gmail.com>

On Fri, Mar 26, 2021 at 03:26:25PM +0700, Bagas Sanjaya wrote:

Show 25 quoted lines

> On 26/03/21 03.10, Junio C Hamano wrote:
> > Bagas Sanjaya <bagasdotme@gmail.com> writes:
> > 
> > > The text says something called a "patch" is prepared one for each
> > > commit, it is suitable for e-mail submission, and "am" is the
> > > command to use it, but does not say what the "patch" really is.  The
> > > description in the page also refers to "three-dash" line, but that
> > > is totally unclear unless the reader is given a more detailed
> > > overview of what the "patch" the first paragraph refers to.
> > > 
> > > Co-authored-by: Junio C Hamano <gitster@pobox.com>
> > > Signed-off-by: Junio C Hamano <gitster@pobox.com>
> > > Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> > > ---
> > 
> > I do not think this was co-authored; you are forwarding somebody
> > else's patch that was written without any input from you.
> > 
> Oh dear...
> 
> Next time when I need to send patches forwarded from you (or others),
> but not necessarily Co-authored-by, what should I do? Something like
> this note below?
> 
> [forwarded from someone]

You should start the first line of the message body with:

  From: Original Author <orig@example.com>

git-send-email will do this automatically if the author of the commit you are sending does not match your identity (you may also need to use "git commit --author" to make sure the author is set correctly in the commit).

-Peff