Re: Git 2.31.1, Solaris and error: conflicting types for 'inet_ntop'

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Mar 28, 2021, 01:26 UTC
Message-ID: <YF/bMjJA2RguVguZ@camp.crustytoothpaste.net>
In-Reply-To: <CAH8yC8mSMZDjhbidruAh9t7QFsv6Yxqi1poNEXBT=Nn9+sB2hA@mail.gmail.com>

On 2021-03-28 at 01:04:32, Jeffrey Walton wrote:

Show 11 quoted lines

> I see what happened... I stopped Autoreconfing so the configure.ac
> changes were not picked up. The original configure is being used.
> 
> I think Git is getting itself into that state.
> 
> Without the Autoreconf, I was able to sidestep the issue with:
> 
> if [[ "${IS_SOLARIS}" -eq 1 ]]; then
>     CONFIG_OPTS+=("ac_cv_func_inet_ntop=yes")
>     CONFIG_OPTS+=("ac_cv_func_inet_pton=yes")
> fi

Most developers don't use the autoconf stuff and just use the makefile. config.mak.uname doesn't have NO_INET_NTOP set for SunOS.

If the autoconf scripts or config.mak.uname need fixing, which is possible, a patch would definitely be welcome.

-- 
brian m. carlson (he/him or they/them)
Houston, Texas, US