git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] builtin/repack.c: do not repack single packs with --geometric

From
Taylor Blau <me@ttaylorr.com>
Date
Mar 5, 2021, 19:30 UTC
Message-ID
<YEKG5XtNxArQe/xH@nand.local>
In-Reply-To
<YEKGLfUM1DSHk74B@nand.local>
On Fri, Mar 05, 2021 at 02:27:41PM -0500, Taylor Blau wrote:
> instead of only when geometry->pack_nr == 0. But I was pretty sure that
> the code below was doing the right thing even for geometry->pack_nr ==
> 1, and so I decided to avoid making this non-special case "special" by
> returning early.

After "I was pretty sure that the code was doing the right", I should note that I did the same thing you did in my head, and then confirmed my thinking by running the tests in t5326.

Re-reading my response, I am worried that I gave the impression of being lackadaisical about testing.

Previous: Taylor BlauNext: Taylor Blau
Message 5 of 12 in “clean-ups to geometric repacking”
  1. 0/5 clean-ups to geometric repackingTaylor Blau, Mar 5, 2021
  2. 1/5 builtin/repack.c: do not repack single packs with --geometricTaylor Blau, Mar 5, 2021
  3. Junio C HamanoMar 5, 2021
  4. Taylor BlauMar 5, 2021
  5. Taylor BlauMar 5, 2021
  6. 2/5 t7703: test --geometric repack with loose objectsTaylor Blau, Mar 5, 2021
  7. 4/5 builtin/repack.c: be more conservative with unsigned overflowsTaylor Blau, Mar 5, 2021
  8. Junio C HamanoMar 5, 2021
  9. Taylor BlauMar 5, 2021
  10. Jeff KingMar 10, 2021
  11. 5/5 builtin/repack.c: reword comment around pack-objects flagsTaylor Blau, Mar 5, 2021
  12. 3/5 builtin/repack.c: assign pack split laterTaylor Blau, Mar 5, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.