Re: [PATCH] block-sha1: drop trailing semicolon from macro definition
Show 14 quoted lines
> 23119ffb4e (block-sha1: put expanded macro parameters in parentheses,
> 2012-07-22) added a trailing semicolon to the definition of SHA_MIX
> without explanation. It doesn't matter with the current code, but make
> sure to avoid potential surprises by removing it again.
>
> This allows the macro to be used almost like a function: Users can
> combine it with operators of their choice, but still must not pass an
> expression with side-effects as a parameter, as it would be evaluated
> multiple times.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> block-sha1/sha1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Yes, it was just a typo.