Re: Bash completion suggests tags for git branch -D

From: Jeff King <peff@peff.net>
Date: Feb 2, 2021, 19:38 UTC
Message-ID: <YBmqT/hvT9wM6yHz@coredump.intra.peff.net>
In-Reply-To: <xmqqpn1igznk.fsf@gitster.c.googlers.com>

On Tue, Feb 02, 2021 at 09:14:39AM -0800, Junio C Hamano wrote:

Show 19 quoted lines

> > Oops. I meant to paste the "before" snippet, but this is obviously after
> > I stuck "-D" in there. It does seem to work. :)
> 
> ;-)
> 
> Before we forget, as you said a few times that everything you send
> here on Git are signed off...
> 
> -- >8 --
> From: Jeff King <peff@peff.net>
> Date: Tue Feb 2 04:02:13 2021 -0500
> Subject: [PATCH] completion: treat "branch -D" the same way as "branch -d"
> 
> Paul Jolly noticed that the former offers not just branches but tags
> as completion candidates.  Mimic how "branch -d" limits its suggestion
> to branch names.
> 
> Signed-off-by: Jeff King <peff@peff.net>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Yeah, this looks fine (though Eric's reported-by suggestion seems reasonable). I endorse the signoff. :)

I had also considered whether a test made sense, but I wasn't at all familiar with the completion tests. It looks like we're not even testing "-d", so I'm happy to proceed without one.

-Peff