Re: [PATCH 2/2] rev-list: add --disk-usage option for calculating disk usage

From: Jeff King <peff@peff.net>
Date: Jan 27, 2021, 23:36 UTC
Message-ID: <YBH5DarZvg/phGjP@coredump.intra.peff.net>
In-Reply-To: <87mtwuvva8.fsf@kyleam.com>

On Wed, Jan 27, 2021 at 06:01:51PM -0500, Kyle Meyer wrote:

Show 10 quoted lines

> > +--disk-usage::
> > +	Suppress normal output; instead, print the sum of the bytes used
> > +	for on-disk storage by the selected objects. This is equivalent
> > +	to piping the output of `rev-list --objects` into
> > +	`git cat-file --batch-check='%(objectsize:disk)', except that it
> 
> [ Just a drive-by typo comment from a reader not knowledgeable enough to
>   review the code change :) ]
> 
> The cat-file command is missing its closing quote.

Thanks for catching that. I should have looked at the output of doc-diff, which does reveal it.

-Peff