git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] ls-refs.c: minimize number of refs visited

From
Jeff King <peff@peff.net>
Date
Jan 19, 2021, 23:11 UTC
Message-ID
<YAdnB3Qy46qQ2to4@coredump.intra.peff.net>
In-Reply-To
<YAdkg7ZijzfB8eMc@nand.local>
On Tue, Jan 19, 2021 at 06:00:19PM -0500, Taylor Blau wrote:
Show 10 quoted lines
> > Good catch. It didn't matter until now because nobody relied on having a
> > NULL entry when no prefix had been added (instead, they always iterated
> > over prefixes->nr). IMHO that is worth fixing as a separate commit.
> 
> Yeah. Even after calling it out as such myself, I promptly forgot it
> when preparing the first patch I sent back to Jacob!
> 
> I didn't pull it out into its own patch, and rather folded it in to my
> 2/2. It has a small call-out of its own, but if you'd prefer it by
> itself, I'm happy to resubmit it with that change included.

It's not a _huge_ deal to me, but I think it is slightly nicer as a separate patch. Plus it can easily be credited to Jacob, so at least he gets some authorship credit out of this. :)

-Peff
Previous: Taylor BlauNext: Jacob Vosmaer
Message 6 of 8 in “ls-refs.c: minimize number of refs visited”
  1. 0/1 ls-refs.c: minimize number of refs visitedJacob Vosmaer, Jan 19, 2021
  2. 1/1 ls-refs.c: minimize number of refs visitedJacob Vosmaer, Jan 19, 2021
  3. Taylor BlauJan 19, 2021
  4. Jeff KingJan 19, 2021
  5. Taylor BlauJan 19, 2021
  6. Jeff KingJan 19, 2021
  7. Jacob VosmaerJan 20, 2021
  8. Jacob VosmaerJan 20, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.