git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/4] t/lib-httpd: drop SSLMutex config

From
Jeff King <peff@peff.net>
Date
Feb 1, 2023, 11:39 UTC
Message-ID
<Y9pPWroQIBh9NR35@coredump.intra.peff.net>
In-Reply-To
<Y9pOmR5fOfCHwYpF@coredump.intra.peff.net>

The SSL config enabled by setting LIB_HTTPD_SSL does not work with Apache versions greater than 2.2, as more recent versions complain about the SSLMutex directive. According to https://httpd.apache.org/docs/current/upgrading.html:

  Directives AcceptMutex, LockFile, RewriteLock, SSLMutex,
  SSLStaplingMutex, and WatchdogMutexPath have been replaced with a
  single Mutex directive. You will need to evaluate any use of these
  removed directives in your 2.2 configuration to determine if they can
  just be deleted or will need to be replaced using Mutex.

Deleting this line will just use the system default, which seems sensible. The original came as part of faa4bc35a0 (http-push: add regression tests, 2008-02-27), but no specific reason is given there (or on the mailing list) for its presence.

Signed-off-by: Jeff King <peff@peff.net>
---
If we can't drop support for 2.2 in patch 2, then this would need to be
adjusted with an IfVersion.
 t/lib-httpd/apache.conf | 1 -
 1 file changed, 1 deletion(-)
diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf
index 332617f10d..51a4fbcf62 100644
--- a/t/lib-httpd/apache.conf
+++ b/t/lib-httpd/apache.conf
@@ -203,7 +203,6 @@ SSLCertificateKeyFile httpd.pem
 SSLRandomSeed startup file:/dev/urandom 512
 SSLRandomSeed connect file:/dev/urandom 512
 SSLSessionCache none
-SSLMutex file:ssl_mutex
 SSLEngine On
 </IfDefine>
 
-- 
2.39.1.767.gb4615b3bd3
Previous: Jeff KingNext: Jeff King
Message 6 of 9 in “t/lib-httpd ssl fixes”
  1. 0/4 t/lib-httpd ssl fixesJeff King, Feb 1, 2023
  2. 1/4 t/lib-httpd: bump required apache version to 2.2Jeff King, Feb 1, 2023
  3. Todd ZullingerFeb 2, 2023
  4. Jeff KingFeb 3, 2023
  5. 2/4 t/lib-httpd: bump required apache version to 2.4Jeff King, Feb 1, 2023
  6. 3/4 t/lib-httpd: drop SSLMutex configJeff King, Feb 1, 2023
  7. 4/4 t/lib-httpd: increase ssl key size to 2048 bitsJeff King, Feb 1, 2023
  8. Todd ZullingerFeb 2, 2023
  9. Jeff KingFeb 3, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.