Re: [PATCH 1/6] t1007: modernize malformed object tests

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 18, 2023, 21:13 UTC
Message-ID: <Y8hhB2U0KD5vXJjZ@nand.local>
In-Reply-To: <Y8hYEgMze3bY44/0@coredump.intra.peff.net>

On Wed, Jan 18, 2023 at 03:35:30PM -0500, Jeff King wrote:

Show 5 quoted lines

> The tests in t1007 for detecting malformed objects have two
> anachronisms:
>
>  - they use "sha1" instead of "oid" in variable names, even though the
>    script as a whole has been adapted to handle sha256

I appreciate you saying that we should s/sha1/oid here. But more importantly, thanks for drawing attention to the fact that this script already handles sha256, and that the update is purely cosmetic.

> ---
>  t/t1007-hash-object.sh | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

These look obviously correct.

Thanks, Taylor