Re: [PATCH] tests: make 'test_oid' print trailing newline

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Dec 19, 2022, 14:03 UTC
Message-ID: <Y6BvKdWJIHKq7GMs@tapette.crustytoothpaste.net>
In-Reply-To: <20221218162905.3508164-1-szeder.dev@gmail.com>

On 2022-12-18 at 16:29:05, SZEDER Gábor wrote:

Show 5 quoted lines

> Arguably we would be better off if 'test_oid' terminated its output
> with a LF.  So let's update 'test_oid' accordingly, update its tests
> in t0000 to account for the extra character in those size tests, and
> remove the now unnecessary 'echo $(...)' command substitutions around
> 'test_oid' invocations as well.

I don't recall that there was a particular reason for me to do it the way that it was, and if the commit message doesn't mention it, I think it's fine to replace it. Perhaps I intended to allow writing the binary form as well as the text form, in which case a newline would be undesirable, but I simply don't recall.

All that to say, I think this patch is fine as it stands.

-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA