[PATCH 1/5] ref-filter: reject arguments to %(HEAD)
- From
Jeff King <peff@peff.net>
- Date
- Dec 14, 2022, 16:18 UTC
- Message-ID
- <Y5n3aePWhM0/MlJm@coredump.intra.peff.net>
- In-Reply-To
- <Y5n3S7cnD7s/AIRL@coredump.intra.peff.net>
The %(HEAD) atom doesn't take any arguments, but unlike other atoms in the same boat (objecttype, deltabase, etc), it does not detect this situation and complain. Let's make it consistent with the others.
Signed-off-by: Jeff King <peff@peff.net> --- ref-filter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ref-filter.c b/ref-filter.c index caf10ab23e..08ac5f886e 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -571,8 +571,10 @@ static int rest_atom_parser(struct ref_format *format, struct used_atom *atom, } static int head_atom_parser(struct ref_format *format, struct used_atom *atom, - const char *arg, struct strbuf *unused_err) + const char *arg, struct strbuf *err) { + if (arg) + return strbuf_addf_ret(err, -1, _("%%(HEAD) does not take arguments")); atom->u.head = resolve_refdup("HEAD", RESOLVE_REF_READING, NULL, NULL); return 0; }
-- 2.39.0.550.g5015380a67