git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6] revision: use calloc instead of malloc where possible

From
Bagas Sanjaya <bagasdotme@gmail.com>
Date
Dec 7, 2022, 08:44 UTC
Message-ID
<Y5BScRmR1fY/SQCq@debian.me>
In-Reply-To
<pull.1390.v6.git.git.1670356394394.gitgitgadget@gmail.com>
On Tue, Dec 06, 2022 at 07:53:14PM +0000, Rose via GitGitGadget wrote:
> From: Seija <doremylover123@gmail.com>
> 
> We can avoid having to call memset by calling calloc
Who are "we"?

Please avoid using first-person pronouns (I and we), since these are ambiguous in context of many entities (individuals/companies) participating in development. Instead, write in imperative mood and passive voice, e.g. "Avoid the need to call memset by allocating with calloc() instead of malloc().".

Even then, what are justifications of malloc() -> calloc() conversion other than the described above?

> 
> Signed-off-by: Seija doremylover123@gmail.com

The SoB doesn't look OK. It should have been "Signed-off-by: Your Real Name <yourname@what.domain>".

Thanks.
-- 
An old man doll... just what I always wanted! - Clara
Previous: Rose via GitGitGadgetNext: AreaZR via GitGitGadget
Message 10 of 16 in “maintenance: use xcalloc instead of xmalloc where possible”
  1. maintenance: use xcalloc instead of xmalloc where possibleRose via GitGitGadget, Dec 5, 2022
  2. Jeff HostetlerDec 5, 2022
  3. maintenance: use xcalloc instead of xmalloc where possibleRose via GitGitGadget, Dec 5, 2022
  4. maintenance: use xcalloc instead of xmalloc where possibleRose via GitGitGadget, Dec 5, 2022
  5. maintenance: use calloc instead of malloc where possibleRose via GitGitGadget, Dec 5, 2022
  6. Junio C HamanoDec 6, 2022
  7. revision: use calloc instead of malloc where possibleRose via GitGitGadget, Dec 6, 2022
  8. Ævar Arnfjörð BjarmasonDec 6, 2022
  9. revision: use calloc instead of malloc where possibleRose via GitGitGadget, Dec 6, 2022
  10. Bagas SanjayaDec 7, 2022
  11. revision: use calloc instead of malloc where possibleAreaZR via GitGitGadget, Dec 18, 2024
  12. git: use calloc instead of malloc where possibleAreaZR via GitGitGadget, Dec 18, 2024
  13. git: use calloc instead of malloc where possibleAreaZR via GitGitGadget, Dec 18, 2024
  14. git: use calloc instead of malloc + memset where possibleAreaZR via GitGitGadget, Dec 18, 2024
  15. Junio C HamanoDec 18, 2024
  16. git: use calloc instead of malloc + memset where possibleAreaZR via GitGitGadget, Dec 18, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.