Re: [PATCH] git-compat-util.h: introduce CALLOC(x)

From: Jeff King <peff@peff.net>
Date: Dec 7, 2022, 06:06 UTC
Message-ID: <Y5AtdwGdWrDQxuuJ@coredump.intra.peff.net>
In-Reply-To: <221206.86r0xdcm2u.gmgdl@evledraar.gmail.com>

On Tue, Dec 06, 2022 at 03:12:08AM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 12 quoted lines

> I'm not saying you *should*, but now that we use C99 macros we *could*
> also make the "1" an optional argument. I.e. these would be the same
> thing:
> 
> 	CALLOC(x)
> 	CALLOC(x, 1)
> 
> And you could also do:
> 
> 	CALLOC(x, 123)
> 
> Whether that makes the interface even nastier is another matter.

Like the INIT proposal you mentioned, I tend to think this is clever but not really a good idea in the long run. I don't mind magic if it's giving us a big benefit, but I don't think that's the case here. :)

-Peff