Re: [PATCH 0/2] fixing parse_object() check for type mismatch

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 18, 2022, 19:05 UTC
Message-ID: <Y3fXYKj8PdS4EKLB@nand.local>
In-Reply-To: <Y3a3qcqNG8W3ueeb@coredump.intra.peff.net>

On Thu, Nov 17, 2022 at 05:37:29PM -0500, Jeff King wrote:

Show 10 quoted lines

> I'm adding Taylor to the cc as the author of t6102, when we were
> tracking down all of these "oops, it's not really a blob" cases. This
> fixes one of the lingering cases from that test script.
>
>   [1/2]: parse_object(): drop extra "has" check before checking object type
>   [2/2]: parse_object(): check on-disk type of suspected blob
>
>  object.c                               | 5 ++---
>  t/t6102-rev-list-unexpected-objects.sh | 4 ++--
>  2 files changed, 4 insertions(+), 5 deletions(-)

A blast from the past :-).

I took a careful look at both of these patches and they looked good to me, so let's start merging them down.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.