Re: [PATCH] notes: avoid empty line in template

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 16, 2022, 19:57 UTC
Message-ID: <Y3VAxO+EQVXVu92z@nand.local>
In-Reply-To: <Y3Uxh25Gh5fPQrMq@coredump.intra.peff.net>

On Wed, Nov 16, 2022 at 01:52:55PM -0500, Jeff King wrote:

Show 13 quoted lines

> > diff --git a/builtin/notes.c b/builtin/notes.c
> > index be51f69225..80d9dfd25c 100644
> > --- a/builtin/notes.c
> > +++ b/builtin/notes.c
> > @@ -181,7 +181,7 @@ static void prepare_note_data(const struct object_id *object, struct note_data *
> >  		strbuf_addch(&buf, '\n');
> >  		strbuf_add_commented_lines(&buf, "\n", strlen("\n"));
> >  		strbuf_add_commented_lines(&buf, _(note_template), strlen(_(note_template)));
> > -		strbuf_addch(&buf, '\n');
> > +		strbuf_add_commented_lines(&buf, "\n", strlen("\n"));
>
> And the patch looks obviously good. The irony is the version two lines
> above which does it correctly. ;)

Thanks, both. ;-).

Thanks, Taylor