git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t7610: fix flaky timeout issue, don't clone from example.com

From
Taylor Blau <me@ttaylorr.com>
Date
Nov 15, 2022, 19:42 UTC
Message-ID
<Y3PrjMLcEGfoHifZ@nand.local>
In-Reply-To
<Y2xfNcCfkij6k4Uk@nand.local>
On Wed, Nov 09, 2022 at 09:17:25PM -0500, Taylor Blau wrote:
Show 14 quoted lines
> On Thu, Nov 10, 2022 at 12:55:30AM +0100, Ævar Arnfjörð Bjarmason wrote:
> > But we generally just fail some or all of 3..9 pretty fast, and don't
> > start taking 20 minutes to run the test, when it took 10s before (or
> > whatever).
>
> OK. I still think that in principle this is indistinguishable from not
> running a setup test to completion.
>
> *But*: I'm willing to treat them differently since instead of
> manifesting in an immediate failure later on in the suite, we hang for a
> substantial period of time.
>
> So I'm content to merge this down, but I don't think it's worth
> searching out for more of these in the future.

Having merged this down to 'next', it looks like there is some CI fallout on the Windows tests, see:

  https://github.com/ttaylorr/git/actions/runs/3473324797/jobs/5805324776

I am not sure how I might have caught this earlier not having a Windows machine myself. Regardless, let's make sure that it is fixed up before this graduates.

Thanks, Taylor

Previous: Taylor BlauNext: Ævar Arnfjörð Bjarmason
Message 5 of 9 in “t7610: fix flaky timeout issue, don't clone from example.com”
  1. t7610: fix flaky timeout issue, don't clone from example.comÆvar Arnfjörð Bjarmason, Nov 5, 2022
  2. Taylor BlauNov 9, 2022
  3. Ævar Arnfjörð BjarmasonNov 9, 2022
  4. Taylor BlauNov 10, 2022
  5. Taylor BlauNov 15, 2022
  6. t7610: use "file:///dev/null", not "/dev/null", fixes MinGWÆvar Arnfjörð Bjarmason, Nov 15, 2022
  7. Taylor BlauNov 16, 2022
  8. Ævar Arnfjörð BjarmasonNov 17, 2022
  9. Taylor BlauNov 17, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.