Re: [PATCH] bisect; remove unused "git-bisect.sh" and ".gitignore" entry
- From
Jeff King <peff@peff.net>
- Date
- Nov 15, 2022, 17:07 UTC
- Message-ID
- <Y3PHOpIqMC9ZT4pg@coredump.intra.peff.net>
- In-Reply-To
- <patch-1.1-7be23b6faa0-20221115T093130Z-avarab@gmail.com>
On Tue, Nov 15, 2022 at 10:32:42AM +0100, Ævar Arnfjörð Bjarmason wrote:
Show 5 quoted lines
> Since fc304fb52f9 (Merge branch 'dd/git-bisect-builtin' into next, > 2022-11-14) we've used builtin/bisect.c instead of git-bisect.sh to > implement the "bisect" command. Let's remove the unused leftover > script, and the ".gitignore" entry for the "git-bisect--helper", which > also hasn't been built since fc304fb52f9.
A small nit, but it's probably not a good idea to refer to merge commits from 'next'. They may be meaningful now, but they aren't part of the long-term history, and will get gc'd eventually when Junio rewinds next after a release. Which will leave this reference useless for people looking at "git log" a year from now.
A better reference is probably 73fce29427 (Turn `git bisect` into a full built-in, 2022-11-10), which will remain stable as it gets merged eventually into master.
> .gitignore | 1 - > git-bisect.sh | 63 ---------------------------------------------------
The patch itself looks like an obviously correct thing to do.
-Peff