git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] docs: clarify that credential discards unrecognised attributes

From
Taylor Blau <me@ttaylorr.com>
Date
Nov 13, 2022, 04:56 UTC
Message-ID
<Y3B48E04XfBiSz2V@nand.local>
In-Reply-To
<Y2/OIrSz+xrqkd+C@coredump.intra.peff.net>
On Sat, Nov 12, 2022 at 11:47:30AM -0500, Jeff King wrote:
Show 26 quoted lines
> On Sat, Nov 12, 2022 at 02:21:24AM +0000, M Hickford wrote:
>
> > On Tue, 25 Oct 2022 at 00:59, Jeff King <peff@peff.net> wrote:
> > >
> > > On Mon, Oct 24, 2022 at 07:57:48AM +0000, M Hickford via GitGitGadget wrote:
> > >
> > > > It was previously unclear how unrecognised attributes are handled.
> > >
> > > Yeah, this was always part of the intended behavior, but I agree we did
> > > not say it very explicitly (aside from an in-code comment!). Both the
> > > intent and content of your patch look good to me.
> >
> > Thanks. What happens next? I should look for this change in the seen
> > branch? https://git-scm.com/docs/MyFirstContribution#after-approval
>
> Usually the maintainer would pick it up, it would end up in seen, then
> eventually 'next', and then eventually 'master'. You can check the
> periodic "What's Cooking" messages from the maintainer to see more
> discussion of various topic branches.
>
> In this case, though, I don't see any indication that the maintainer
> picked saw it. It sometimes happens that a topic is simply overlooked,
> even if it received positive reviews.
>
> The usual thing to do is repost it, cc-ing the maintainer. I've also
> cc'd the interim maintainer here, so that may get things moving. :)

I think that Junio may have missed it when picking up topics. But it happened before I start combing the list more finely, so I had already purged it from my inbox without picking it up, either.

I'll take a look now and queue it to start merging down. Thanks for the nudge.

Thanks, Taylor

Previous: Jeff King
Message 13 of 13 in “docs: clarify that credential discards unrecognised attributes”
  1. docs: clarify that credential discards unrecognised attributesM Hickford via GitGitGadget, Oct 24, 2022
  2. Jeff KingOct 24, 2022
  3. Jeff KingOct 25, 2022
  4. ThanksM Hickford, Oct 25, 2022
  5. Bagas SanjayaOct 25, 2022
  6. M HickfordOct 26, 2022
  7. Jeff KingOct 26, 2022
  8. Junio C HamanoOct 26, 2022
  9. M HickfordNov 12, 2022
  10. Jeff KingNov 12, 2022
  11. M HickfordNov 12, 2022
  12. Jeff KingNov 14, 2022
  13. Taylor BlauNov 13, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.