Re: [PATCH] Makefile: fix cygwin build failure

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 10, 2022, 02:20 UTC
Message-ID: <Y2xf7HbAdqXOmgR3@nand.local>
In-Reply-To: <221110.868rkjpty3.gmgdl@evledraar.gmail.com>

On Thu, Nov 10, 2022 at 12:18:01AM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 19 quoted lines

>
> On Wed, Nov 09 2022, Taylor Blau wrote:
>
> > Hi Ramsay,
> >
> > On Wed, Nov 09, 2022 at 10:46:05PM +0000, Ramsay Jones wrote:
> >> Commit 1c97a5043f (Makefile: define "TEST_{PROGRAM,OBJS}" variables
> >> earlier, 2022-10-31) breaks the cygwin build, like so:
> >
> > It seems reasonable to me, and I'd like to pick it up rather quickly (on
> > top of Ævar's branch), especially if this is going to break things
> > downstream in Git for Windows.
> >
> > Ævar: this sort of change is a little tricky to review without more diff
> > context ;-). Do you have any objections to me slotting this on top of
> > your branch?
>
> Yes, I've reviewed this, sorry about missing this edge case. This fix &
> analysis looks solid to me (it's still just in "seen", right?)

Yes, 'ab/remove--super-prefix' is only in seen for now. So that we don't break the Cygwin build in the middle of history, could you send a reroll of that topic that incorporates this patch squashed into the right location so that each step builds independently?

Thanks, Taylor