Re: [PATCH 0/3] chainlint: emit line numbers alongside test definitions

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 9, 2022, 22:22 UTC
Message-ID: <Y2woMwY2CmteZwgS@nand.local>
In-Reply-To: <pull.1413.git.1668013114.gitgitgadget@gmail.com>

On Wed, Nov 09, 2022 at 04:58:31PM +0000, Eric Sunshine via GitGitGadget wrote:

> This patch series further assists the test author by displaying line numbers
> alongside the annotated test definition, thus allowing the author to jump
> directly to each problematic line.

This is really nifty. I applied it on top of your earlier series, intentionally broke a test and got some very pleasing chainlint output after trying to run it.

As previously, I am no expert in the chainlint code, but everything here looks pretty reasonable to me. And certainly it works, so I'm inclined to start merging this and the other topic down.

It would be nice to have some more familiar eyes take a look at it, though.

> (Note to self: Fortify against Ævar's nerd-snipe blacklist evasion.)

;-).

Thanks, Taylor