Re: [RFC PATCH 0/8] Get rid of "git --super-prefix"

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 9, 2022, 21:21 UTC
Message-ID: <Y2wZw3eYO4ykwtA8@nand.local>
In-Reply-To: <RFC-cover-0.8-00000000000-20221109T192315Z-avarab@gmail.com>

On Wed, Nov 09, 2022 at 08:34:28PM +0100, Ævar Arnfjörð Bjarmason wrote:

> An RFC alternative to Glen's [1], and what I *thought* he might be be
> going for in the earlier discussion[2].

I am a little puzzled with what to do with this series. For one, it doesn't seem to apply cleanly on top of 'ab/remove--super-prefix':

    $ git log --oneline -1
    04e36effde (HEAD -> ab/remove--super-prefix) Merge branch 'ab/submodule-helper-prep-only' into ab/remove--super-prefix

    $ git am -sc3 ~/patch
    Applying: submodule--helper: don't use global --super-prefix in "absorbgitdirs"
    error: sha1 information is lacking or useless (submodule.c).
    error: could not build fake ancestor
    Patch failed at 0001 submodule--helper: don't use global --super-prefix in "absorbgitdirs"
    hint: Use 'git am --show-current-patch=diff' to see the failed patch
    When you have resolved this problem, run "git am --continue".
    If you prefer to skip this patch, run "git am --skip" instead.
    To restore the original branch and stop patching, run "git am --abort".

But it would be nice to have a clearer path forward between this and Glen's series. I understand that they are both still RFCs, but I am counting on you two working together to find a path forward that is satisfactory to you both.

In the meantime, it would be nice to have a version of this series that I can apply to start playing around with.

Thanks, Taylor