Re: [PATCH v2 00/15] leak fixes: use existing constructors & other trivia

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 8, 2022, 20:54 UTC
Message-ID: <Y2rB9Ol7307mrw4r@nand.local>
In-Reply-To: <cover-v2-00.15-00000000000-20221108T172650Z-avarab@gmail.com>

On Tue, Nov 08, 2022 at 07:17:36PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 12 quoted lines

> This is a bag of simple leak fixes, mostly one-line additions where we
> use existing destructors. See [1] for v1.
>
> Changes since v1:
>
>  * Rebased on pw/rebase-no-reflog-action, per [2].
>  * It'll merge just fine without pw/rebase-no-reflog-action, but some
>    of the tests marked as leak-free will still leak then. So, in
>    practice they can be staged independently, as long as
>    pw/rebase-no-reflog-action is merged down first.
>  * The 10/15 here has an updated explanation about why we were leaking
>    that value. see also[3].

Looking good. I did a --no-ff merge of 'pw/rebase-no-reflog-action' into this topic, and pushed out the result.

Let's start merging it down.

Thanks, Taylor