Re: safe.directory and ACLs

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 3, 2022, 00:11 UTC
Message-ID: <Y2MHNeSrhxfH1Ayf@nand.local>
In-Reply-To: <CAJyRyRqMPX93-Oa5XMvZtDTRxh0SisUhOFAWhv-6hXR5sEkQpA@mail.gmail.com>

On Wed, Nov 02, 2022 at 04:41:15PM -0700, John Soo wrote:

Show 11 quoted lines

> Hi brian!
>
> > No, the permissions of a repository, whether standard Unix permissions
> > or ACLs, are not relevant to ownership.  The question here is whether
> > the owner of the .git directory (that is, the value of the `st_uid`
> > field when calling lstat(2) on it) is equal to the effective user ID.
> >
> > When you the path in `ls`, you can see the owner and group of the file
> > specified, and that owner is what matters here.
>
> I see. Is that by design or an implementation detail?

It is by design. See 8959555cee7 (setup_git_directory(): add an owner check for the top-level directory, 2022-03-02) for details.

Thanks, Taylor