Re: [PATCH] t: run t5551 tests with both HTTP and HTTP/2
- From
Jeff King <peff@peff.net>
- Date
- Nov 11, 2022, 15:19 UTC
- Message-ID
- <Y25oAj+OdC4s+jJM@coredump.intra.peff.net>
- In-Reply-To
- <221111.86wn81mssk.gmgdl@evledraar.gmail.com>
On Fri, Nov 11, 2022 at 04:06:20PM +0100, Ævar Arnfjörð Bjarmason wrote:
Show 7 quoted lines
> > In theory other http-related test scripts could benefit from the same > > duplication, but doing t5551 should give us a reasonable check of basic > > functionality, and would have caught both bugs we've seen in the wild > > with HTTP/2. > > Looking at the diff below, would it be much more work to just support a > GIT_TEST_HTTP_VERSION=2?
No, but 99% of the tests would not benefit (because they don't run http at all), and it would consume a bunch of extra CPU.
> There's the "!HTTP2" additions, which you mention you'll be "fixing > momentarily", but this is a stand-alone patch, so maybe I'm missing that > context...
The other context is Glen's patch that started this thread.
-Peff