git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] repack: don't remove .keep packs with `--pack-kept-objects`

From
Taylor Blau <me@ttaylorr.com>
Date
Oct 21, 2022, 03:14 UTC
Message-ID
<Y1IOhH2jAwHHrLY+@nand.local>
In-Reply-To
<Y05NwIfY/906b2Vd@coredump.intra.peff.net>
On Tue, Oct 18, 2022 at 02:54:56AM -0400, Jeff King wrote:
> So the patch looks good to me as-is (and sorry for the verbose review;
> we've just had enough tricky corner cases in this repack code that I
> wanted to make sure I understood all the implications).

Yeah, I agree that this is probably premature optimization, but in practice it doesn't hurt much. Copying it was definitely intentional, and I share your general unease about changing it in this patch.

Thanks, Taylor

Previous: Jeff King
Message 3 of 3 in “repack: don't remove .keep packs with `--pack-kept-objects`”
  1. repack: don't remove .keep packs with `--pack-kept-objects`Taylor Blau, Oct 18, 2022
  2. Jeff KingOct 18, 2022
  3. Taylor BlauOct 21, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.