Re: [RFC PATCH v2] shortlog: add group-by options for year and month

From: Jeff King <peff@peff.net>
Date: Oct 11, 2022, 01:00 UTC
Message-ID: <Y0TAG3k1wK+ZfdzY@coredump.intra.peff.net>
In-Reply-To: <Y0CnJBzTbNgRIqZ+@nand.local>

On Fri, Oct 07, 2022 at 06:24:36PM -0400, Taylor Blau wrote:

Show 15 quoted lines

> > So here you're allowing multiple pretty options. But really, once we
> > allow the user an arbitrary format, is there any reason for them to do:
> >
> >   git shortlog --group=%an --group=%ad
> >
> > versus just:
> >
> >   git shortlog --group='%an %ad'
> >
> > ?
> 
> I think that if you want to unify `--group=author` into the new format
> group implementation, you would have to allow multiple `--group`
> options, but each such option would generate its own shortlog identity
> instead of getting concatenated together.

Exactly, and I think we have to do that anyway to match the existing multiple-option behavior.

-Peff