Re: [PATCH v2] ci: add address and undefined sanitizer tasks

From: Jeff King <peff@peff.net>
Date: Oct 11, 2022, 00:28 UTC
Message-ID: <Y0S4q/GBlTcK6Y1R@coredump.intra.peff.net>
In-Reply-To: <xmqqpmezxl9p.fsf@gitster.g>

On Mon, Oct 10, 2022 at 05:21:38PM -0700, Junio C Hamano wrote:

Show 25 quoted lines

> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 831f4df56c..92d27db0b9 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -251,6 +251,9 @@ jobs:
>            - jobname: linux-leaks
>              cc: gcc
>              pool: ubuntu-latest
> +          - jobname: linux-sanitize
> +            cc: gcc
> +            pool: ubuntu-latest
>      env:
>        CC: ${{matrix.vector.cc}}
>        CC_PACKAGE: ${{matrix.vector.cc_package}}
> diff --git a/ci/lib.sh b/ci/lib.sh
> index 1b0cc2b57d..c9c4982e21 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -278,6 +278,9 @@ linux-leaks)
>  	export GIT_TEST_PASSING_SANITIZE_LEAK=true
>  	export GIT_TEST_SANITIZE_LEAK_LOG=true
>  	;;
> +linux-sanitize)
> +	export SANITIZE=address,undefined
> +	;;

Looks fine to me (and I obviously endorse the goal :) ).

-Peff