Re: [PATCH 03/16] t5541: simplify and move "no empty path components" test

From: Jeff King <peff@peff.net>
Date: Feb 24, 2023, 02:11 UTC
Message-ID: <Y/gcxkqZutHa90QC@coredump.intra.peff.net>
In-Reply-To: <xmqqttzc3qeq.fsf@gitster.g>

On Thu, Feb 23, 2023 at 03:36:45PM -0800, Junio C Hamano wrote:

Show 6 quoted lines

> > As a bonus, this also lets us drop the check for the v0 protocol (which
> > is otherwise necessary since v2 makes multiple requests, and
> > check_access_log insists on exactly matching the number of requests,
> > even though we don't care about that here).
> 
> Makes me wonder why we do not clear the log for each test, but OK.

Yes, I think that is a better strategy than the current code, but IMHO these targeted greps are even better at showing what we really care about. After my series, there are only two calls to check_access_log left:

  - the one in t5541, from patch 2. This could be a grep, but since
    there is no v0/v2 confusion it was easy enough to leave it (and
    after my patch, it now is clearing and checking the activity of just
    one test)

  - one in t5561, which really does want to check the results after a
    ton of manual requests

So I think the state after my series is OK, at least from a maintenance perspective.

-Peff