Re: mc/credential-helper-www-authenticate (Re: What's cooking in git.git (Feb 2023, #04; Wed, 22))

From: Jeff King <peff@peff.net>
Date: Feb 23, 2023, 09:48 UTC
Message-ID: <Y/c2dQTohGsN+3Me@coredump.intra.peff.net>
In-Reply-To: <3ab86863-fa15-a5c5-08c8-73ad775e04c8@github.com>

On Wed, Feb 22, 2023 at 09:51:28PM -0800, Victoria Dye wrote:

Show 16 quoted lines

> Junio C Hamano wrote:
> > * mc/credential-helper-www-authenticate (2023-02-16) 3 commits
> >  - credential: add WWW-Authenticate header to cred requests
> >  - http: read HTTP WWW-Authenticate response headers
> >  - t5563: add tests for basic and anoymous HTTP access
> > 
> >  Allow information carried on the WWW-AUthenticate header to be
> >  passed to the credential helpers.
> > 
> >  Will merge to 'next'?
> >  source: <pull.1352.v10.git.1676586881.gitgitgadget@gmail.com>
> 
> Aside from some relatively minor touch-ups, this has been fairly stable
> since v8. I'm happy with it at this point, but I'm also curious to hear
> Peff's thoughts (since it was his review that prompted the switch to Apache
> for the test helper, among other changes).

I just gave v10 a careful read. It looks quite nice to me, though there were a few tiny nits that I think are worth a re-roll (the most important being the strcasecmp buffer over-read).

-Peff