Re: [Bug] Test 1450.91 Fails on NonStop

From: Jeff King <peff@peff.net>
Date: Feb 15, 2023, 18:02 UTC
Message-ID: <Y+0eIlsIxRr+1RYp@coredump.intra.peff.net>
In-Reply-To: <000001d94165$3d1cf2f0$b756d8d0$@nexbridge.com>

On Wed, Feb 15, 2023 at 12:44:59PM -0500, rsbecker@nexbridge.com wrote:

> + + git hash-object -w --stdin
> + test-tool genzeros 104857601
> blob=e69de29bb2d1d6434b8b29ae775ad8c2e48c5391

That's not right. e69de29bb is the empty blob. A hundred megabytes (plus one) of zeroes should be d748d1b68b9dc69c4717ebc070dbc547d129bcc6.

So that is the root of your problem (the empty file will obviously not trigger the "too large" fsck check), but I don't know why it would be failing.

Maybe check the output of "test-tool genzeros 104857601" to make sure that it as expected? If not, then the bug is somewhere in t/helper/test-genzeros.c.

It's on the left-hand side of pipe. Maybe it is getting a write() error, but we are ignoring it? Maybe a patch like this would help diagnose:

diff --git a/t/helper/test-genzeros.c b/t/helper/test-genzeros.c
index 8ca988d621..0574917005 100644
--- a/t/helper/test-genzeros.c
+++ b/t/helper/test-genzeros.c
@@ -18,14 +18,14 @@ int cmd__genzeros(int argc, const char **argv)
 	/* Writing out individual NUL bytes is slow... */
 	while (count < 0)
 		if (write(1, zeros, ARRAY_SIZE(zeros)) < 0)
-			return -1;
+			die_errno("write()");
 
 	while (count > 0) {
 		n = write(1, zeros, count < ARRAY_SIZE(zeros) ?
 			  count : ARRAY_SIZE(zeros));
 
 		if (n < 0)
-			return -1;
+			die_errno("write()");
 
 		count -= n;
 	}

-Peff