Re: [PATCH v2 1/2] Add project-wide .vimrc configuration

From: Jeff King <peff@peff.net>
Date: Dec 10, 2020, 15:27 UTC
Message-ID: <X9I+eisn7sQuWZ1J@coredump.intra.peff.net>
In-Reply-To: <CAMP44s19FKYT5LNUxbGZP3czFmhe9t5B-FAfH+V2btNvMNW31g@mail.gmail.com>

On Wed, Dec 09, 2020 at 07:55:55PM -0600, Felipe Contreras wrote:

Show 12 quoted lines

> >   - t0 is specifying not to indent function return types when they
> >     appear on a separate line. But our style is not to put those return
> >     types on a separate line, anyway. Do we need this?
> 
> Right. I recall at some point it was annoying me that types were auto
> indented magically at wrong times. Testing "ts" that doesn't seem to
> happen anymore, but it also doesn't seem to be working at all.
> 
> Do you see some difference from "t0" and "ts" with:
> 
>   void
>   main(void) { }

No, but picking it does seem to impact a larger example. If I open up wt-status.c and modify the first function to be:

  static const char *
  color(int slot, struct wt_status *s)
  {

then reindenting it with t0 versus ts makes a difference (and I do prefer the t0 behavior). But we would not use that split-line style in our project in the first place, I don't think.

-Peff