Re: [PATCH] doc: 'T' status code for git status

From: Jeff King <peff@peff.net>
Date: Dec 9, 2020, 17:37 UTC
Message-ID: <X9ELRf7s9sBcs9CD@coredump.intra.peff.net>
In-Reply-To: <pull.930.git.git.1607501616914.gitgitgadget@gmail.com>

On Wed, Dec 09, 2020 at 08:13:36AM +0000, Julien Richard via GitGitGadget wrote:

> From: Julien Richard <julien.richard@ubisoft.com>
> 
> Git status can return 'T' status code which stands for "typechange", fixing the documentation accordingly.

Thanks, this is definitely an omission in the documentation.

I wonder if we need a little more, though. The list here:

Show 10 quoted lines

> --- a/Documentation/git-status.txt
> +++ b/Documentation/git-status.txt
> @@ -197,6 +197,7 @@ codes can be interpreted as follows:
>  * 'R' = renamed
>  * 'C' = copied
>  * 'U' = updated but unmerged
> +* 'T' = type changed
>  
>  Ignored files are not listed, unless `--ignored` option is in effect,
>  in which case `XY` are `!!`.

is followed by a table showing the meaning of those entries in each slot. Should there be some "T" entries there, too?

I think it could basically show up anywhere that "M" could.

>     Git status can return 'T' status code which stands for "typechange". I
>     can't document more the behavior but it would have helped me a lot to
>     see that line in the documentation so I guess it can help others too.

It is correctly documented in the diff manpage. There we define it as "change in the type of the file". I'm not sure if that's really making anything clearer than "type changed". ;)

Perhaps "type changed (e.g., a symbolic link becoming a file)" would be more descriptive, but I'm not sure it's necessary. (And if so, it probably would be better placed in the diff documentation).

-Peff