Re: [PATCH v2] builtin/bugreport.c: use thread-safe localtime_r()

From: Jeff King <peff@peff.net>
Date: Dec 2, 2020, 01:57 UTC
Message-ID: <X8b0he9VVI5s1log@coredump.intra.peff.net>
In-Reply-To: <xmqqlfehqt4n.fsf@gitster.c.googlers.com>

On Tue, Dec 01, 2020 at 10:27:20AM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > We might also want to do this on top:
> >
> > -- >8 --
> > Subject: [PATCH] banned.h: mark non-reentrant gmtime, etc as banned
> 
> I see the patch does more than what subject describes.  
> 
> I am not opposed to banning ctime_r() and asctime_r(), but I do not
> want to see our future readers wonder why they are banned by the
> commit whose title clearly states that we refuse non-reentrant ones
> in our codebase.

Well, not more than the overall commit message describes. :)

But yeah, the split in what you re-sent is just fine with me. Thanks for saving a round-trip. I see you already fixed up the typo in the second one pointed out by Eric, but I think there is another:

  s/stftime/strftime/

-Peff