Re: [PATCH v3] crendential-store: use timeout when locking file
On Wed, Nov 25, 2020 at 06:31:23PM +0000, Simão Afonso wrote:
Show 14 quoted lines
> When holding the lock for rewriting the credential file, use a timeout
> to avoid race conditions when the credentials file needs to be updated
> in parallel.
>
> An example would be doing `fetch --all` on a repository with several
> remotes that need credentials, using parallel fetching.
>
> The timeout can be configured using "credentialStore.lockTimeoutMS",
> defaulting to 1 second.
>
> Signed-off-by: Simão Afonso <simao.afonso@powertools-tech.com>
> ---
>
> lockTimeoutMS sounds like the consensual name, implemented.
Thanks, this version looks good to me.
-Peff