Re: test-tool: bloom: generate_filter for multiple string?

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 13, 2021, 15:13 UTC
Message-ID: <X/8OLozuyx+rxEHN@nand.local>
In-Reply-To: <X/7guF05a/Bb/VNp@danh.dev>

On Wed, Jan 13, 2021 at 06:59:52PM +0700, Đoàn Trần Công Danh wrote:

Show 14 quoted lines

> On 2021-01-12 14:53:32-0500, Taylor Blau <me@ttaylorr.com> wrote:
> > On Thu, Dec 31, 2020 at 10:54:38AM +0700, Đoàn Trần Công Danh wrote:
> > > I'm reading the code for Bloom Filter to see if arXiv:2012.00472
> > > could be an improvement.
> >
> > I'm late to the party, but I'm curious to hear which part of this
> > article you think would help out the Bloom filter implementation.
>
> Uhm, no. The article doesn't help the Bloom filter implementation.
> The article was suggesting using Bloom filter to speed-up the
> negotiation in fetch-pack and upload-pack. Which, in my own quick
> experience, doesn't help much. Maybe it's me not understand the
> article idea or I have made a naive implementation. However, I'm not
> convinced to pursued further.

I see. I read your "reading the code for Bloom Filter to see if ... could be an improvement" as trying to improve the Bloom implementation. Which after skimming the article, made me quite curious, since I didn't understand what you were getting at.

But trying to speed up the negotiation makes sense, and is in line with the goal of the article. It's too bad that you weren't able to produce the same benefits here, but I understand why.

> If you are curious, I'm attaching 2 quick-and-low-quality patches with
> this email for your consideration.

Thanks. They were an interesting read.

Thanks, Taylor