Re: [PATCH] git-remote: load config whenever create_symref() might be called

From: Jérémie Detrey <jeremie.detrey@altu.fr>
Date: Dec 26, 2020, 22:28 UTC
Message-ID: <X+e48UEE4wf3fMNI@pica>
In-Reply-To: <xmqqeejcqlpq.fsf@gitster.c.googlers.com>

Hi,

Thanks for the feedback!

Junio C Hamano:

Show 6 quoted lines

> My gut feeling says that the best place to call git_config() on
> git_default_config would actually be in cmd_remote(), immediately
> before we call parse_options() to parse the main options shared by
> all subcommands of "git remote".  Is there a reason why codepaths
> other than the three you singled out should *not* be affected by the
> basic set of configuration variables?

No, none that I can think of. I'll leave more knowledgeable people than me confirm this, but if that's the way to go, I'll be happy to submit a revised patch following your suggestion :)

Cheers, Jérémie.