Re: not all tests pass when on an NFS partition
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Feb 17, 2009, 16:32 UTC
- Message-ID
- <UeTsTvDfFT9ToLdKosYcgFRx4HzMKUFpn67jts4q-qNPzYZVyG8DQQ@cipher.nrlssc.navy.mil>
- In-Reply-To
- <3a69fa7c0902170641m2ba9b8aeo950c9e3868ba6244@mail.gmail.com>
E R wrote:
> Btw - what kind of risks are involved in using git when test > t5304-prune.sh doesn't pass? Do we risk repository corruption?
For the case in the test, git-prune is failing to remove an object that it should, which won't cause repo corruption. It will just cause retention of an object for longer than it is needed. I suspect this is caused by some flaw in the NFS client (disclosure: IANAKH).
In practice, I don't think you'll experience this flaw. I think it shows up in the test because we are manually adjusting the mtime of the objects and then immediately trying to prune them and this must tweak whatever code has a bug.
I have been using git on 5.2 for a couple of months now with no problem. Admittedly, prune is a rare operation, usually triggered by git-gc.
-brandon