Re: [RFC PATCH 00/95] Add missing &&'s in the testsuite

From: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>
Date: Sep 24, 2010, 21:32 UTC
Message-ID: <UA25cdpM3towJy13l2VNc8pgKHGybUWr88Zc0C9kQjUCExhj5gXkCQ@cipher.nrlssc.navy.mil>
In-Reply-To: <1285362413-18265-1-git-send-email-newren@gmail.com>

On 09/24/2010 04:06 PM, Elijah Newren wrote:

Show 16 quoted lines

> I ran across three testfiles which were missing &&s; one was missing
> several, while another would no longer pass after adding one and had
> no comment to that effect.  So I decided it was time to look through
> the testsuite.  Now I have a 95 patch series, which I'm worried might
> be a bit too much spam for the mailing list.  So the patches are
> available from
>    git://gitorious.org/~newren/git/en.git   add-missing-ands
> Let me know if you're fine with mailing list spam, and I'd be happy
> to flood all your inboxes.
> 
> 80 of the 95 testfiles that needed changes were pretty mechanical --
> just simple additions of '&&' in the appropriate place.  15 needed
> other changes and I'm not entirely sure whether I made the right ones.
> I've moved those 15 to the beginning of the series, so that you won't
> have to hunt for them.  (If it makes sense to send just the first 15
> to the list, let me know, and I'll do that.)

Sounds like it should be about a 16 patch series.

The first 15 patches should rework the tests that will fail when they are hooked together properly with &&'s.

And then one patch to mechanically add the missing &&'s.

Maybe even some of the first 15 patches could be squashed if any of them apply the same fix, just to different test files.

-Brandon