Re: [PATCH v3] add: support pre-add hook

From: Chandra <chandrakr@pm.me>
Date: Feb 25, 2026, 02:15 UTC
Message-ID: <TjRZg9NlROW7rOZkb70ZxSqGHVSP91O5kV9uWyXR9Z41GyCSYDbY1xPBTEowgHkx5xZYVSR35eLxTdpkHRP0DxmtkZoJt1CoUjBzv9bQdCI=@pm.me>
In-Reply-To: <oxAq83GHpc_Iuijrz10UxkyWknKQ0E3AilBFvKqNJg1OpO4ldNr5NUIsit3gSMjjO8dqG_t0FB4uAgYyrmLN4VGyx_ZeZOWh5qogrAiDWVc=@pm.me>

Thanks again for the review. I prepared v3 with the lockfile argument model, a mixed-result gating fix, a 'post-index-change' contract fix, and docs updates.

Chandra Kethi-Reddy @archonphronesis:matrix.org

Sent from Proton Mail for iOS.

-------- Original Message -------- On Thursday, 02/12/26 at 03:25 Chandra <Chandrakr@pm.me> wrote: In the git-commit documentation, pre-commit is always verbatim. For consistency, pre-add typeset as verbatim makes sense.

Chandra Kethi-Reddy

Sent from Proton Mail for iOS.

-------- Original Message -------- On Thursday, 02/12/26 at 02:56 Junio C Hamano <gitster@pobox.com> wrote: Chandra <Chandrakr@pm.me> writes:

>> the word pre-add ... would not look good
>
> Originally, I wanted to call these pre-staging hooks.

I was not talking about the choice of words. If pre-commit interferes before a commit is made in 'git commit', pre-add is a natural phrase to use to interfere 'git add'.

It was a comment only on how it is typeset in the documentation, e.g., should it be `pre-add` (for verbatim), 'pre-add', _pre_add_, etc.