Re: [PATCH v3 0/5] repack: don't lose objects to a ".keep" that appears mid-run

From: Qin ShiCheng <qeesung@live.com>
Date: Oct 9, 2026, 03:07 UTC
Message-ID: <SJ0PR84MB29933F55E298B09B37F2778EDD922@SJ0PR84MB2993.NAMPRD84.PROD.OUTLOOK.COM>
In-Reply-To: <xmqqv77cyp8u.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> I do not know if you meant to cram a function on four lines this
> way,

I did not; GitGitGadget reflowed the indented block in the PR description. It was meant to read

	void repo_invalidate_kept_pack_caches(struct repository *r)
	{
		struct odb_source_files *files = odb_source_files_downcast(r->objects->source);

		for (struct odb_files_dir *dir = files->dirs; dir; dir = dir->next)
			invalidate_kept_pack_cache(dir->packed);
	}

> but I suspect that it may be easier for everybody to stop and
> wait until the other topic solidifies a bit more, and then create a
> synthetic base that merges the other topic into the tip of 'master'
> and rebase these five patches on top of the resulting merge.

Makes sense. I will hold off until ps/odb-files-alternates settles, then send v4 on top of master with that topic merged in, and say so in the cover letter.

Thanks, Qin