git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[BUG] git-web unable to show this commit properly?

From
DCDexuan Cui <decui@microsoft.com>
Date
Jun 19, 2023, 21:37 UTC
Message-ID
<SA1PR21MB1335BD64334ABD240C23C43ABF5FA@SA1PR21MB1335.namprd21.prod.outlook.com>

Hi, "git show 122333d6bd229af279cdb35d1b874b71b3b9ccfb --stat" shows the below:

commit 122333d6bd229af279cdb35d1b874b71b3b9ccfb
Author: Nikolay Borisov <nik.borisov@suse.com>
Date:   Fri May 5 15:03:32 2023 +0300
    x86/tdx: Wrap exit reason with hcall_func()
    TDX reuses VMEXIT "reasons" in its guest->host hypercall ABI.  This is
    confusing because there might not be a VMEXIT involved at *all*.
    These instances are supposed to document situation and reduce confusion
    by wrapping VMEXIT reasons with hcall_func().
    The decompression code does not follow this convention.
    Unify the TDX decompression code with the other TDX use of VMEXIT reasons.
    No functional changes.
    Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
    Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
    Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Link: https://lore.kernel.org/all/20230505120332.1429957-1-nik.borisov%40suse.com
 arch/x86/boot/compressed/tdx.c    |  4 ++--
 arch/x86/coco/tdx/tdx.c           | 11 -----------
 arch/x86/include/asm/shared/tdx.h | 11 +++++++++++
 3 files changed, 13 insertions(+), 13 deletions(-)

But the web interface only shows " 1 files changed, 0 insertions, 11 deletions" https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/arch/x86/coco?id=122333d6bd229af279cdb35d1b874b71b3b9ccfb (Note: the correct info should be "3 files changed, 13 insertions(+), 13 deletions(-)", as shown above by git-show)

Looks like this may have something to do with Rename Detection? But IMO the web interface should at least show "3 files changed", otherwise it's confusing...

Thanks, -- Dexuan

Next: Andreas Schwab
Message 1 of 3 in “[BUG] git-web unable to show this commit properly?”
  1. Dexuan CuiJun 19, 2023
  2. Andreas SchwabJun 19, 2023
  3. Dexuan CuiJun 19, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.