[PATCH FYI] Work around sed issues
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Aug 19, 2008, 00:18 UTC
- Message-ID
- <RJmd_We0BRt641swOemkgHiaYcXguvcn3HcZHHGRLDm-254BgNjVCw@cipher.nrlssc.navy.mil>
- In-Reply-To
- <IH0MHSTEimhAN93AedvpRKq4qfzm1QA814ZYyhbSBtSdNbq8vuE6aw@cipher.nrlssc.navy.mil>
/usr/xpg4/bin/sed exits non-zero if the sed script is not newline terminated. /bin/sed does not have this problem, so use it instead where possible.
But, /bin/sed does not handle tab correctly. For this case in t4200, rework the test so that the exit status of sed does not affect the outcome of the test, and use /usr/xpg4/bin/sed (which is in the PATH).
--- t/annotate-tests.sh | 2 +- t/t4118-apply-empty-context.sh | 2 +- t/t4200-rerere.sh | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh index cacb273..14ee531 100644 --- a/t/annotate-tests.sh +++ b/t/annotate-tests.sh @@ -114,7 +114,7 @@ test_expect_success \ test_expect_success \ 'some edit' \ 'mv file file.orig && - sed -e "s/^3A/99/" -e "/^1A/d" -e "/^incomplete/d" < file.orig > file && + /bin/sed -e "s/^3A/99/" -e "/^1A/d" -e "/^incomplete/d" < file.orig > file && echo "incomplete" | tr -d "\\012" >>file && GIT_AUTHOR_NAME="D" git commit -a -m "edit"' diff --git a/t/t4118-apply-empty-context.sh b/t/t4118-apply-empty-context.sh index f92e259..c064f7b 100755 --- a/t/t4118-apply-empty-context.sh +++ b/t/t4118-apply-empty-context.sh @@ -23,7 +23,7 @@ test_expect_success setup ' cat file2 >file2.orig git add file1 file2 && sed -e "/^B/d" <file1.orig >file1 && - sed -e "/^[BQ]/d" <file2.orig >file2 && + /bin/sed -e "/^[BQ]/d" <file2.orig >file2 && echo Q | tr -d "\\012" >>file2 && cat file1 >file1.mods && cat file2 >file2.mods && diff --git a/t/t4200-rerere.sh b/t/t4200-rerere.sh index b68ab11..834f52f 100755 --- a/t/t4200-rerere.sh +++ b/t/t4200-rerere.sh @@ -189,8 +189,9 @@ test_expect_success 'file2 added differently in two branches' ' echo Bello > file2 && git add file2 && git commit -m version2 && - test_must_fail git merge fourth && - sha1=$(sed -e "s/ .*//" .git/MERGE_RR) && + test_must_fail git merge fourth || return 1 + sha1=$(sed -e "s/ .*//" .git/MERGE_RR) + test -n "$sha1" && rr=.git/rr-cache/$sha1 && echo Cello > file2 && git add file2 &&
-- 1.6.0.11.gecc7e