Re: [PATCH 5/5] Signing API: Duplicated signing tests using new config aliases
- From
- Ibrahim El <ibrahim.el@pm.me>
- Date
- Aug 27, 2019, 18:54 UTC
- Message-ID
- <REK5vbm4i5ut8-lShrc8zcI0FhegDvy49CM2CXn4QS7prThNuwiu5J1Ae_kCh5c29Ri157tB86UXJH372WEFo_uWW9y7wf3oh1ysMZphs4c=@pm.me>
- In-Reply-To
- <20190826230704.GC11334@genre.crustytoothpaste.net>
Thx for your feedback. I will update the necessary existing tests and re-submit the patches.
Ibrahim El Rhezzali
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Monday, August 26, 2019 11:07 PM, brian m. carlson <sandals@crustytoothpaste.net> wrote:
Show 15 quoted lines
> On 2019-08-26 at 19:58:10, Ibrahim El wrote: > > > From: Ibrahim El Rhezzali ibrahim.el@pm.me > > c6a1d1c21 Duplicated signing tests using new config aliases > > Duplicating existing tests that are signature related and updating them to use the new config aliases > > I don't think we want to duplicate all of these tests. Perhaps we could > add a small number of additional tests in an existing signing test that > makes sure both the new and the old configuration work as expected, and > assume that the entire codebase will honor those config settings. > > -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > brian m. carlson: Houston, Texas, US > OpenPGP: https://keybase.io/bk2204