git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[commit 4ecbc178704] Incosistency?

From
UUnknown <borg@uu3.net>
Date
Jul 14, 2009, 21:41 UTC
Message-ID
<Pine.LNX.4.64.0907142335210.31779@cube>
commit 4ecbc178704ca6c1027a38483e98f5fe493b1322
Author: Jeff King <peff@peff.net>
Date:   Thu Jul 9 02:37:35 2009 -0400

bla bla.. some strange SUDO fix (who the hell uses git that way?) I dont like it.. git-add in libexecdir was good!

diff --git a/Makefile b/Makefile
index 78cc113..311ce7d 100644
--- a/Makefile
+++ b/Makefile
@@ -1641,15 +1641,15 @@ ifneq (,$X)
  endif
         bindir=$$(cd '$(DESTDIR_SQ)$(bindir_SQ)' && pwd) && \
         execdir=$$(cd '$(DESTDIR_SQ)$(gitexec_instdir_SQ)' && pwd) && \
-       { $(RM) "$$execdir/git-add$X" && \
+       { $(RM) "$$execdir/git$X" && \
                 test -z "$(NO_CROSS_DIRECTORY_HARDLINKS)" && \
-               ln "$$bindir/git$X" "$$execdir/git-add$X" 2>/dev/null || \
-               cp "$$bindir/git$X" "$$execdir/git-add$X"; } && \
-       { for p in $(filter-out git-add$X,$(BUILT_INS)); do \
+               ln "$$bindir/git$X" "$$execdir/git$X" 2>/dev/null || \
+               cp "$$bindir/git$X" "$$execdir/git$X"; } && \
+       { for p in $(BUILT_INS); do \
                 $(RM) "$$execdir/$$p" && \
-               ln "$$execdir/git-add$X" "$$execdir/$$p" 2>/dev/null || \
-               ln -s "git-add$X" "$$execdir/$$p" 2>/dev/null || \
-               cp "$$execdir/git-add$X" "$$execdir/$$p" || exit; \
+               ln "$$execdir/git$X" "$$execdir/$$p" 2>/dev/null || \
+               ln -s "git$X" "$$execdir/$$p" 2>/dev/null || \
+               cp "$$execdir/git$X" "$$execdir/$$p" || exit; \
           done; } && \
         ./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"

Isnt check_bindir is broken now?
git-add is no more..
Next: Jeff King
Message 1 of 7 in “[commit 4ecbc178704] Incosistency?”
  1. UnknownJul 14, 2009
  2. Jeff KingJul 14, 2009
  3. Johannes SchindelinJul 14, 2009
  4. UnknownJul 15, 2009
  5. Jeff KingJul 15, 2009
  6. UnknownJul 17, 2009
  7. Thomas AdamJul 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.