git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] First step, making setup (somewhat) reentrant

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 7, 2008, 11:28 UTC
Message-ID
<Pine.LNX.4.64.0801071227110.14355@wbgn129.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7v4pdq0z30.fsf@gitster.siamese.dyndns.org>
Hi,
On Mon, 7 Jan 2008, Junio C Hamano wrote:
Show 11 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Which brings me to a more fundamental question: what do you need 
> > reentrant setup_directory() for?  If it is just to allow multiple 
> > calls to that function for the _same_ repository, I say clean up your 
> > code.
> 
> IIRC, he is writing a set-of-repositories browser.
> 
> But I think the right approach of cleaning up is to design a
> layer of containers like we did for "the_index" libification

Yes, I concur. That was a nice abstraction without impacting existing code too much.

Ciao, Dscho

Previous: Junio C Hamano
Message 8 of 8 in “Add streq() to compat-util”
  1. 1/5 Add streq() to compat-utilChristian Thaeter, Jan 7, 2008
  2. 2/5 First step, making setup (somewhat) reentrantChristian Thaeter, Jan 7, 2008
  3. 3/5 provide a reset_packed_git() functionChristian Thaeter, Jan 7, 2008
  4. 4/5 Export some more functions to enable resetting the git stateChristian Thaeter, Jan 7, 2008
  5. 5/5 Make setup_git_directory reentrantChristian Thaeter, Jan 7, 2008
  6. Johannes SchindelinJan 7, 2008
  7. Junio C HamanoJan 7, 2008
  8. Johannes SchindelinJan 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.