Re: [PATCH 2/5] First step, making setup (somewhat) reentrant
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 7, 2008, 11:28 UTC
- Message-ID
- <Pine.LNX.4.64.0801071227110.14355@wbgn129.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <7v4pdq0z30.fsf@gitster.siamese.dyndns.org>
Hi,
On Mon, 7 Jan 2008, Junio C Hamano wrote:
Show 11 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > Which brings me to a more fundamental question: what do you need > > reentrant setup_directory() for? If it is just to allow multiple > > calls to that function for the _same_ repository, I say clean up your > > code. > > IIRC, he is writing a set-of-repositories browser. > > But I think the right approach of cleaning up is to design a > layer of containers like we did for "the_index" libification
Yes, I concur. That was a nice abstraction without impacting existing code too much.
Ciao, Dscho