Re: [PATCH v0] sha1_name: grok <revision>:./<relative-path>

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 20, 2007, 10:51 UTC
Message-ID: <Pine.LNX.4.64.0712201145390.14355@wbgn129.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vr6hirx5l.fsf@gitster.siamese.dyndns.org>

Hi,

On Wed, 19 Dec 2007, Junio C Hamano wrote:

Show 30 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > diff --git a/cache.h b/cache.h
> > index 39331c2..83a2c31 100644
> > --- a/cache.h
> > +++ b/cache.h
> > @@ -225,6 +225,7 @@ extern char *get_index_file(void);
> >  extern char *get_graft_file(void);
> >  extern int set_git_dir(const char *path);
> >  extern const char *get_git_work_tree(void);
> > +extern const char *get_current_prefix(void);
> >  
> >  #define ALTERNATE_DB_ENVIRONMENT "GIT_ALTERNATE_OBJECT_DIRECTORIES"
> >  
> > diff --git a/setup.c b/setup.c
> > index b59dbe7..fb9b680 100644
> > --- a/setup.c
> > +++ b/setup.c
> > @@ -3,6 +3,12 @@
> >  
> >  static int inside_git_dir = -1;
> >  static int inside_work_tree = -1;
> > +static const char *current_prefix;
> > +
> > +const char *get_current_prefix()
> > +{
> > +	return current_prefix;
> > +}
> 
> Didn't you just make libification harder?

Well, yes.

Actually, no:

	- I marked this explicitely not ready for application,
	- it is not entirely clear if a libgit.a user would not want to 
	  set a default prefix, and
	- I decided that I will not be the only one who tries to make 
		  libification easy. ;-)

Ciao, Dscho