Re: builtin command's prefix question
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 6, 2007, 15:48 UTC
- Message-ID
- <Pine.LNX.4.64.0712061547070.27959@racer.site>
- In-Reply-To
- <fcaeb9bf0712060726r383c3a36j798a439b9dbb0cae@mail.gmail.com>
Hi,
On Thu, 6 Dec 2007, Nguyen Thai Ngoc Duy wrote:
Show 16 quoted lines
> On Dec 6, 2007 6:22 AM, Junio C Hamano <gitster@pobox.com> wrote: > > However, if we define setup() to behave this way when GIT_DIR is not > > defined and GIT_WORK_TREE is: > > > > (1) internally pretend as if GIT_DIR was specified to be the > > directory where the command was started from (iow, do getcwd() > > once upon startup); > > > > (2) chdir to GIT_WORK_TREE (which means "callers of setup() always > > run from the top of the work tree"); > > > > (3) set prefix to NULL; > > (1) is fine by me, even if it goes up to find a gitdir. But (3), no, > prefix should be set as relative path from worktree top directory to > user current directory, not NULL.
If you expect "git <command> <filespec>" to work correctly from GIT_DIR, you will _have_ to set the prefix to NULL.
Ciao, Dscho