git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add option --path to allow to run tests with real systems. You must install git before running this test.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 6, 2007, 15:23 UTC
Message-ID
<Pine.LNX.4.64.0712061422010.27959@racer.site>
In-Reply-To
<20071206134817.GA8523@laptop>
Hi,
On Thu, 6 Dec 2007, Nguyễn Thái Ngọc Duy wrote:
Show 13 quoted lines
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  On Thu, Dec 06, 2007 at 10:15:05AM +0700, Nguyen Thai Ngoc Duy wrote:
>  > On Dec 6, 2007 2:32 AM, Junio C Hamano <gitster@pobox.com> wrote:
>  > > This is wrong, isn't it?  $path may point at the freshly built but not
>  > > installed git executable, but it reports --exec-path the location that
>  > > git-foo and friends are to be _eventually_ installed, not the location
>  > > they are sitting after built, being tested, waiting to be installed.
>  > >
>  > Yes, forgot to mention you must do "make install" first :)
>  > 
> 
>  Perhaps a check to remind people to 'make install' like this?

Well, the whole point of "make test" is to be sure that it works before installing it.

How about something completely different?
-- snipsnap --
 t/test-lib.sh |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 90b6844..ee87b83 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -296,7 +296,18 @@ test_done () {
 
 # Test the binaries we have just built.  The tests are kept in
 # t/ subdirectory and are run in trash subdirectory.
-PATH=$(pwd)/..:$PATH
+
+# Test libexec, while we are at it
+
+test -d test-bin || mkdir test-bin || error "t/test-bin/ could not be created"
+for file in ../git ../git-sh-setup ../test-*
+do
+	target=test-bin/"$(basename "$filename")"
+	test -x "$file" && test ! -x "$target" &&
+		ln -s ../"$file" test-bin/
+done
+
+PATH=$(pwd)/test-bin:$PATH
 GIT_EXEC_PATH=$(pwd)/..
 GIT_TEMPLATE_DIR=$(pwd)/../templates/blt
 GIT_CONFIG=.git/config
Previous: Nguyễn Thái Ngọc DuyNext: Johannes Schindelin
Message 4 of 5 in “Add option --path to allow to run tests with real systems”
  1. Add option --path to allow to run tests with real systemsNguyễn Thái Ngọc Duy, Dec 5, 2007
  2. Junio C HamanoDec 5, 2007
  3. Add option --path to allow to run tests with real systems. You must install git before running this test.Nguyễn Thái Ngọc Duy, Dec 6, 2007
  4. Johannes SchindelinDec 6, 2007
  5. Johannes SchindelinDec 6, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.